🩹 [Patch]: Switch to use GITHUB_TOKEN for updates
#43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction in Update-FontsData script
…in Update-FontsData script
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the font data update workflow by removing dependencies on the GitHub App authentication and introducing a new native command wrapper. The changes simplify the script execution by using standard git operations instead of app-based authentication.
- Introduces
Invoke-NativeCommandfunction to standardize native command execution with error handling - Updates workflow permissions and removes GitHub App authentication requirements
- Removes the "Agave" font entry from the fonts data
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/FontsData.json | Removes the "Agave" font entry from the available fonts list |
| scripts/Update-FontsData.ps1 | Adds Invoke-NativeCommand function and refactors git commands to use it instead of direct calls |
| .github/workflows/Update-FontsData.yml | Updates permissions and removes GitHub App authentication parameters |
…nhance git operations in script
…ay changes, commit details, and diffs
MariusStorhaug
changed the title
GITHUB_TOKEN for updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces significant updates to the workflow and script for automating the process of updating font data. The changes improve functionality, add clarity, and enhance error handling. Key updates include adjustments to permissions, modifications to the GitHub Actions workflow, and a major overhaul of the
Update-FontsData.ps1script to streamline Git operations and improve logging.Workflow updates:
.github/workflows/Update-FontsData.yml: Updated permissions to includecontents: writeandpull-requests: write, enabling the workflow to push changes and create pull requests..github/workflows/Update-FontsData.yml: Addedfetch-depth: 0to the repository checkout step, ensuring all history is fetched for operations requiring full commit history. Removed unusedClientIDandPrivateKeyinputs from theUpdate-FontsDatajob.Script enhancements:
scripts/Update-FontsData.ps1: Replaced raw Git commands with a newInvoke-NativeCommandfunction for executing native commands, improving error handling and debugging capabilities.scripts/Update-FontsData.ps1: Enhanced branch management logic to dynamically switch between default and feature branches based on context, ensuring proper handling of updates and pull requests.scripts/Update-FontsData.ps1: Improved logging and added detailed output for changes, commits, and diffs, providing better visibility into the update process.Type of change
Checklist